Skip to content

Add support for GCP + Oauth2 credentials#42

Merged
uz1pk merged 2 commits intodevelopfrom
uz/external-systems
Aug 13, 2025
Merged

Add support for GCP + Oauth2 credentials#42
uz1pk merged 2 commits intodevelopfrom
uz/external-systems

Conversation

@uz1pk
Copy link
Copy Markdown
Contributor

@uz1pk uz1pk commented Aug 13, 2025

Before this PR

After this PR

  • Bump external-systems
  • Add support for GCP + Oauth2 creds generated by backend

Are Docs needed?

  • README.md already links to external-systems lib which references this

@changelog-app
Copy link
Copy Markdown

changelog-app Bot commented Aug 13, 2025

Generate changelog in changelog/@unreleased

Type (Select exactly one)

  • Feature (Adding new functionality)
  • Improvement (Improving existing functionality)
  • Fix (Fixing an issue with existing functionality)
  • Break (Creating a new major version by breaking public APIs)
  • Deprecation (Removing functionality in a non-breaking way)
  • Migration (Automatically moving data/functionality to a new system)

Description

Bump external-systems lib

Check the box to generate changelog(s)

  • Generate changelog entry

@uz1pk uz1pk changed the title Bump external-systems lib Add support for GCP + Oauth2 credentials Aug 13, 2025
@changelog-app
Copy link
Copy Markdown

changelog-app Bot commented Aug 13, 2025

Successfully generated changelog entry!

What happened?

Your changelog entries have been stored in the database as part of our migration to ChangelogV3.

Need to regenerate?

Simply interact with the changelog bot comment again to regenerate these entries.

@uz1pk uz1pk marked this pull request as ready for review August 13, 2025 21:35
@uz1pk uz1pk requested a review from Copilot August 13, 2025 21:36
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for GCP OAuth2 and generic OAuth2 credentials by bumping the external-systems dependency and implementing credential parsing for these new authentication types.

  • Bumps external-systems from ^0.100.0 to ^0.107.0 to support new credential types
  • Adds parsing logic for GCP OAuth2 and generic OAuth2 credentials in the source configuration
  • Expands test coverage to verify the new credential types work correctly

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
pyproject.toml Updates external-systems dependency version to support new credential types
compute_modules/sources_v2/_sources.py Adds credential parsing functions for GCP OAuth2 and generic OAuth2 credentials
tests/sources_v2/test_sources.py Adds comprehensive test coverage for the new credential types and refactors existing test names

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

Comment thread tests/sources_v2/test_sources.py Outdated
Comment thread tests/sources_v2/test_sources.py Outdated
@uz1pk uz1pk merged commit a9b2fc3 into develop Aug 13, 2025
11 checks passed
@autorelease3
Copy link
Copy Markdown

autorelease3 Bot commented Aug 13, 2025

Released 0.28.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants